[PATCH] D43966: [WebAssembly] Simplify COMDAT handling.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I think that's a right direction, though that should be done as a separate patch after this.

Your change needs to change llvm/lib/Object/WasmObjectFile.cpp right? One thing I noticed there is that WasmObjectFile::parseLinkingSectionComdat does an expensive test using a set. I don't think that's we want check for name uniqueness in WasmObjectFile.cpp, as it should be a lightweight wrapper to read object files as quickly as possible.


https://reviews.llvm.org/D43966