[PATCH] D43964: Report an error if you try to link against .dll instead of .lib.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

"It is a usage error to feed a .dll file instead of a .dll to COFF linker"

Should be

"It is a usage error to feed a .dll file instead of a .lib to COFF linker"

Do you think it's worth printing a nicer error for the specific case of DLLs (something that tells the user they should be linking against the import library instead)? In particular, binutils supports linking against DLLs directly (it synthesizes an import library on the fly), so a nicer error message could be helpful for users coming from that toolchain.



================
Comment at: lld/COFF/Driver.cpp:135
     break;
-
   case file_magic::archive:
----------------
Is it standard LLVM or LLD coding style to not have the newlines?


https://reviews.llvm.org/D43964