[PATCH] D43729: [CallSiteSplitting] properly split musttail calls

[Fedor Indutny via Phabricator via llvm-commits]

indutny added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:338
+  // FIXME: remove TI above, once https://reviews.llvm.org/D43822 lands
+  {
+    SmallVector<BasicBlock *, 2> Splits(predecessors((TailBB)));
----------------
fhahn wrote:
> We  should only do that for musttail calls, otherwise we crash.
> 
> I think we hit a slightly different problem here that won't be fixed by D43822. A different iterator gets invalidated. I'll have a closer look tomorrow.
Ooops. I'll take a look at it today, hopefully this won't be in conflict with your work since you plan to start tomorrow.


https://reviews.llvm.org/D43729