[PATCH] D43956: [DebugInfo] Discard invalid DBG_VALUE instructions in LiveDebugVariables

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 11:34:35 PST 2018


bjope added a comment.

In https://reviews.llvm.org/D43956#1024189, @bjope wrote:

> In https://reviews.llvm.org/D43956#1024090, @aprantl wrote:
>
> > - Dropping invalid DBG_VALUE instructions is not correct. What you want to do is insert a `DBG_VALUE undef, ...`.
>
>
> Yes, that should be more correct. I'll look into such a solution tomorrow.


Although, since the DBG_VALUE is misplaced from the start, then we do not know if it is correct to insert a `DBG_VALUE undef, ..., !"x"` in that position in the code. Perhaps it could be in a scope where "x" doesn't exist?


Repository:
  rL LLVM

https://reviews.llvm.org/D43956





More information about the llvm-commits mailing list