[PATCH] D43940: [WebAssembly] Reorder reloc sections to come after symtab and validate section order
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 1 10:07:42 PST 2018
sbc100 added inline comments.
================
Comment at: lib/MC/WasmObjectWriter.cpp:1310
writeDataSection();
+ writeLinkingMetaDataSection(SymbolInfos, InitFuncs, Comdats);
writeCodeRelocSection();
----------------
Sorry to be a pain but perhaps we can land this single line change (and the associated test updates) on its own? Then we can bikeshed about the best way to validate ordering at our leisure :)
In also makes sense to me since changing the order, and validating the order can be seen as distinct changes.
Repository:
rL LLVM
https://reviews.llvm.org/D43940
More information about the llvm-commits
mailing list