[PATCH] D43913: Delay writing the PDB build id until just before file commit.

[Zachary Turner via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD326453: [PDB] Defer writing the build id until the rest of the PDB is written. (authored by zturner, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D43913?vs=136429&id=136559#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D43913

Files:
  COFF/PDB.cpp


Index: COFF/PDB.cpp
===================================================================
--- COFF/PDB.cpp
+++ COFF/PDB.cpp
@@ -1056,12 +1056,10 @@
 
   // Add an Info stream.
   auto &InfoBuilder = Builder.getInfoBuilder();
-  InfoBuilder.setAge(BuildId.PDB70.Age);
-
   GUID uuid;
   memcpy(&uuid, &BuildId.PDB70.Signature, sizeof(uuid));
+  InfoBuilder.setAge(BuildId.PDB70.Age);
   InfoBuilder.setGuid(uuid);
-  InfoBuilder.setSignature(time(nullptr));
   InfoBuilder.setVersion(pdb::PdbRaw_ImplVer::PdbImplVC70);
 
   // Add an empty DBI stream.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43913.136559.patch
Type: text/x-patch
Size: 549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180301/d39f5447/attachment.bin>