[PATCH] D43946: [WebAssembly] Reorder reloc sections to come after symtab

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:637
-    createRelocSections();
+  if (Config->Relocatable)
     createLinkingSection();
-  }
----------------
ncw wrote:
> sbc100 wrote:
> > Why not just swap these two lines?   I'm not sure we should care about where these sections come relative the name section.   
> It's easier to have the name section come before the reloc section - it just makes the yaml2wasm logic a bit simpler. That's not really a good reason is it :( But it would be an extra few lines of code to have "name" come after "reloc".
> 
> You're right we do have free choice on that ordering; all the other orderings are driven by decent reasons.
Can you remind me why it makes yaml2wasm simpler?b


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43946