[PATCH] D43948: [ELF] - Report error when memory region is overflowed by data commands.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 09:10:26 PST 2018


> +// Expands the memory region to the specified size.
> +static void expandMemoryRegion(MemoryRegion *MemRegion, uint64_t Size,
> +                               StringRef RegionName, StringRef SecName) {
> +  MemRegion->CurPos += Size;

This is not expanding *to* the specified size, it is expanding *by* the
specified size.

LGTM with the comment updated.

Thanks,
Rafael


More information about the llvm-commits mailing list