[PATCH] D43819: [ELF] - Restrict section offsets that exceeds file size.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 04:01:34 PST 2018


jhenderson added inline comments.


================
Comment at: test/ELF/linkerscript/sections-va-overflow.s:7
+# RUN: echo "  .text : { *(.text*) } : ph_text " >> %t.script
+# RUN: echo "  .test 0x1000 : { BYTE(0) } }" >> %t.script
+# RUN: not ld.lld -o %t.so --script %t.script %t.o 2>&1 | FileCheck %s -check-prefix=ERR
----------------
I think you should explicitly place .bss somewhere that would cause a problem, similar to .text, as otherwise the test is going to rely on the implicit nature of orphan section handling.


https://reviews.llvm.org/D43819





More information about the llvm-commits mailing list