[llvm] r311631 - [Support] Rewrite handleAllErrors in terms of cantFail.

[Lang Hames via llvm-commits]

You're right. Thanks for catching that Rafael!

Fixed in r326413.

Cheers,
Lang.

-- Lang.

On Wed, Feb 28, 2018 at 1:26 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Sorry for just noticing it, but:
>
> > +/// Behaves the same as handleErrors, except that it requires that all
> > +/// errors be handled by the given handlers. If any unhandled error
> remains
> > +/// after the handlers have run, report_fatal_error() will be called.
>
> It actually calls llvm_unreachable. If it is considered a usage bug for
> this code to see an Error we should update the documentation, if not,
> the code.
>
> > +template <typename... HandlerTs>
> > +void handleAllErrors(Error E, HandlerTs &&... Handlers) {
> > +  cantFail(handleErrors(std::move(E), std::forward<HandlerTs>(
> Handlers)...));
> > +}
>
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/3b8c79ad/attachment.html>