[PATCH] D43896: [XRay] cache symbolized function names for a repeatedly queried function ID

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 17:47:16 PST 2018


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

Just one suggested change, but should be good to land after.

Thanks, @pelikan!



================
Comment at: tools/llvm-xray/func-id-helper.h:31
   const FunctionAddressMap &FunctionAddresses;
+  mutable std::unordered_map<int32_t, std::string> CachedNames;
 
----------------
Can you use an `llvm::DenseMap` instead of the standard (poorly performing) one instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D43896





More information about the llvm-commits mailing list