[PATCH] D43913: Delay writing the PDB build id until just before file commit.

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 136429.
zturner added a comment.

Re-write this to have `PDBFileBuilder` emit the signature.  It's still done as the last step though, so that we can drop in a hash in a followup.

This was a little awkward, because in the case of something like yamlToPdb we actually want to use the exact value in the yaml and not recompute it.  I made it work by having the `InfoStreamBuilder` allow you to optionally set the signature, and if it's not set, it will use the computed value.


https://reviews.llvm.org/D43913

Files:
  lld/COFF/PDB.cpp
  llvm/include/llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h
  llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43913.136429.patch
Type: text/x-patch
Size: 4046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180301/8e0ea439/attachment.bin>