[PATCH] D43729: [CallSiteSplitting] properly split musttail calls
Jun Bum Lim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 13:39:29 PST 2018
junbuml added a comment.
What I didn't want to have initially was creating unreachable to rely on DuplicateInstructionsInSplitBetween to clone BitCast/Ret. As a way to avoid that, I suggested to separate handling musttail from existing cloning. I think what Florian suggested could make fixMustTailCallSite even simpler. If you make fixMustTailCallSite to handle each pred split instead of handling two preds splits, I think you can call the modified fixMustTailCallSite instead of doing CallPN->addIncoming() in splitCallSite();
https://reviews.llvm.org/D43729
More information about the llvm-commits
mailing list