[PATCH] D43627: [DEBUGINFO] Add flag for DWARF2 or less to use sections as references.

Wed Feb 28 13:21:58 PST 2018

Oh, sure, I know you need it I just wanted to separate "can we use a
section relocation" from "should we emit these sections". The latter can be
handled the same way we're planning to handle the rest of the conditional
emission.

-eric

On Wed, Feb 28, 2018 at 1:08 PM Alexey Bataev <a.bataev at outlook.com> wrote:

> Unfortunately, I can't commit everything else without this patch. It will definitely break the compilation of ptx files.
>
> -------------
> Best regards,
> Alexey Bataev
>
> 28.02.2018 16:04, Eric Christopher пишет:
>
>
>
> On Wed, Feb 28, 2018 at 1:02 PM Alexey Bataev via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> ABataev added a comment.
>>
>> In https://reviews.llvm.org/D43627#1022609
>> <https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD43627%231022609&data=02%7C01%7C%7C7bbf5fc8944e49fc542008d57eeeed99%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636554487011067680&sdata=kd5OVnYezYu1jsqgji8K03%2FYJYvIpDWZiRCmL2cBiwQ%3D&reserved=0>,
>> @echristo wrote:
>>
>> > Using sections as references is, in general, a good idea when we can so
>> I'd rather not tie that to whether or not we emit certain sections. If you
>> don't mind reverting that aspect of the change I'd appreciate it and we can
>> get that in via some other preference or a strict requirement via the asm
>> printer as we're planning on doing for the rest of the nvptx section
>> emission.
>>
>>
>> These sections have labels inside of them + they are not supported by PTX
>> format. Ok, I will revert the patch.
>>
>>
> Sure. Adding back everything else is fine to commit btw. We can worry
> about when to use section relocations rather than label relocations in a
> different patch though.
>
> -eric
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/438133d3/attachment.html>