[PATCH] D43834: Fix use after free in PDB linker.

[Alexandre Ganea via Phabricator via llvm-commits]

aganea accepted this revision.
aganea added a comment.

Tested & verified on our use-case.

Some stats:

                      PDB servers linked-in [1] | Target PDB size | Mem used [2] | Mem w/o strong ref [3]
  Project"A" -                  104             |      360 Mb     |    3.1 Gb    |      *crash*
  Project"B" -                   70             |      1.8 Gb     |     18 Gb    |       17.8 Gb
  Project"C" -                  112             |      865 Mb     |    6.2 Gb    |      *crash*

[1] LoadedPDBs.size()
[2] Memory used by LLD just before calling PDB.commit();
[3] w/o the line `LoadedPDBs.push_back(std::move(*ExpectedSession));` :


https://reviews.llvm.org/D43834