[PATCH] D43759: [SCEV] Smarter logic in computeConstantDifference

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 03:38:55 PST 2018


mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:9455
 
   Optional<APInt> LDiff = computeConstantDifference(LHS, FoundLHS);
   Optional<APInt> RDiff = computeConstantDifference(RHS, FoundRHS);
----------------
Also incorrect, because types of LHS and FoundLHS doesn't have to match.


https://reviews.llvm.org/D43759





More information about the llvm-commits mailing list