[PATCH] D43863: [ELF] - Do not remove empty sections that use symbols in expressions.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 03:33:38 PST 2018
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with nit.
@ruiu / @espindola should probably still review it, as I'm aware that there's a little bit of concern about adding extra class members sometimes.
================
Comment at: ELF/OutputSections.cpp:89
+ // other expressions. We add script symbols as undefined, and want to ensure
+ // all of them are defined in output, hence have to keep them.
+ if (ExpressionsUseSymbols)
----------------
defined in output -> defined in the output
https://reviews.llvm.org/D43863
More information about the llvm-commits
mailing list