[PATCH] D43819: [ELF] - Restrict section offsets that exceeds file size.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 03:13:26 PST 2018
grimar added inline comments.
================
Comment at: ELF/Writer.cpp:1913
+ rangeToString(Sec->Offset, Sec->Offset + Sec->Size) +
+ ", check your linker script for overflows");
+ }
----------------
jhenderson wrote:
> ", check" -> ". Check"
I do not think we use dots + uppercases in error messages. I used `;` instead,
it seems a bit hard to find few long error for reference, but at least it is consistent with
"can't create dynamic relocation R_386_GOT32X against symbol: foo in readonly segment; recompile object files with -fPIC"
https://reviews.llvm.org/D43819
More information about the llvm-commits
mailing list