[PATCH] D43854: [WebAssembly] Return a StringRef instead of std::string from getSectionName(). NFC.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 27 19:14:02 PST 2018
ruiu created this revision.
ruiu added a reviewer: sbc100.
Herald added subscribers: sunfish, aheejin, jgravelle-google, dschuff, jfb.
[WebAssembly] Return a StringRef instead of std::string from getSectionName(). NFC.
https://reviews.llvm.org/D43854
Files:
lld/wasm/OutputSections.cpp
lld/wasm/OutputSections.h
Index: lld/wasm/OutputSections.h
===================================================================
--- lld/wasm/OutputSections.h
+++ lld/wasm/OutputSections.h
@@ -35,7 +35,7 @@
: Type(Type), Name(Name) {}
virtual ~OutputSection() = default;
- std::string getSectionName() const;
+ StringRef getSectionName() const;
void setOffset(size_t NewOffset) {
log("setOffset: " + toString(*this) + ": " + Twine(NewOffset));
Offset = NewOffset;
Index: lld/wasm/OutputSections.cpp
===================================================================
--- lld/wasm/OutputSections.cpp
+++ lld/wasm/OutputSections.cpp
@@ -58,17 +58,17 @@
// Returns a string, e.g. "FUNCTION(.text)".
std::string lld::toString(const OutputSection &Sec) {
if (!Sec.Name.empty())
- return Sec.getSectionName() + "(" + Sec.Name + ")";
+ return (Sec.getSectionName() + "(" + Sec.Name + ")").str();
return Sec.getSectionName();
}
-std::string OutputSection::getSectionName() const {
+StringRef OutputSection::getSectionName() const {
return sectionTypeToString(Type);
}
void OutputSection::createHeader(size_t BodySize) {
raw_string_ostream OS(Header);
- debugWrite(OS.tell(), "section type [" + Twine(getSectionName()) + "]");
+ debugWrite(OS.tell(), "section type [" + getSectionName() + "]");
encodeULEB128(Type, OS);
writeUleb128(OS, BodySize, "section size");
OS.flush();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43854.136218.patch
Type: text/x-patch
Size: 1404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/f134785f/attachment-0001.bin>
More information about the llvm-commits
mailing list