[PATCH] D43849: [WebAssembly] Simplify createDefined. NFC.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu created this revision.
ruiu added a reviewer: sbc100.
Herald added subscribers: sunfish, aheejin, jgravelle-google, dschuff, jfb.

[WebAssembly] Simplify createDefined. NFC.


https://reviews.llvm.org/D43849

Files:
  lld/wasm/InputFiles.cpp


Index: lld/wasm/InputFiles.cpp
===================================================================
--- lld/wasm/InputFiles.cpp
+++ lld/wasm/InputFiles.cpp
@@ -196,6 +196,9 @@
   if (!Sym.isDefined())
     return nullptr;
 
+  StringRef Name = Sym.Info.Name;
+  uint32_t Flags = Sym.Info.Flags;
+
   switch (Sym.Info.Kind) {
   case WASM_SYMBOL_TYPE_FUNCTION: {
     InputFunction *Func = getFunction(Sym);
@@ -205,9 +208,8 @@
     }
 
     if (Sym.isBindingLocal())
-      return make<DefinedFunction>(Sym.Info.Name, Sym.Info.Flags, this, Func);
-    return Symtab->addDefinedFunction(Sym.Info.Name, Sym.Info.Flags, this,
-                                      Func);
+      return make<DefinedFunction>(Name, Flags, this, Func);
+    return Symtab->addDefinedFunction(Name, Flags, this, Func);
   }
   case WASM_SYMBOL_TYPE_DATA: {
     InputSegment *Seg = getSegment(Sym);
@@ -220,17 +222,13 @@
     uint32_t Size = Sym.Info.DataRef.Size;
 
     if (Sym.isBindingLocal())
-      return make<DefinedData>(Sym.Info.Name, Sym.Info.Flags, this, Seg, Offset,
-                               Size);
-    return Symtab->addDefinedData(Sym.Info.Name, Sym.Info.Flags, this, Seg,
-                                  Offset, Size);
+      return make<DefinedData>(Name, Flags, this, Seg, Offset, Size);
+    return Symtab->addDefinedData(Name, Flags, this, Seg, Offset, Size);
   }
   case WASM_SYMBOL_TYPE_GLOBAL:
     if (Sym.isBindingLocal())
-      return make<DefinedGlobal>(Sym.Info.Name, Sym.Info.Flags, this,
-                                 getGlobal(Sym));
-    return Symtab->addDefinedGlobal(Sym.Info.Name, Sym.Info.Flags, this,
-                                    getGlobal(Sym));
+      return make<DefinedGlobal>(Name, Flags, this, getGlobal(Sym));
+    return Symtab->addDefinedGlobal(Name, Flags, this, getGlobal(Sym));
   }
   llvm_unreachable("unkown symbol kind");
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43849.136209.patch
Type: text/x-patch
Size: 1880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/e939b153/attachment.bin>