[PATCH] D43845: [WebAssembly] Fix reportUndefinedUndefines.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 17:14:10 PST 2018


ruiu created this revision.
ruiu added a reviewer: sbc100.
Herald added subscribers: sunfish, aheejin, jgravelle-google, dschuff, jfb.

No test fails with this change. Do we need this condition?


https://reviews.llvm.org/D43845

Files:
  lld/wasm/SymbolTable.cpp


Index: lld/wasm/SymbolTable.cpp
===================================================================
--- lld/wasm/SymbolTable.cpp
+++ lld/wasm/SymbolTable.cpp
@@ -51,8 +51,7 @@
         error(toString(File) + ": undefined symbol: " + toString(*Sym));
 
   for (Symbol *Sym : Undefs)
-    if (!Sym->getFile())
-      error("undefined symbol: " + toString(*Sym));
+    error("undefined symbol: " + toString(*Sym));
 }
 
 Symbol *SymbolTable::find(StringRef Name) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43845.136203.patch
Type: text/x-patch
Size: 462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/17335235/attachment.bin>


More information about the llvm-commits mailing list