[PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

It seems this messed up the computation of load addresses for symbols in the androids vdso:

  Symtab, num_symbols = 5:
                 Debug symbol
                 |Synthetic symbol
                 ||Externally Visible
                 |||
  Index   UserID DSX Type            File Address/Value Load Address       Size               Flags      Name
  ------- ------ --- --------------- ------------------ ------------------ ------------------ ---------- ----------------------------------
  [    0]      1   X Code            0x00000000ffffe410 0x00000410 0x0000000000000008 0x00000012 __kernel_rt_sigreturn
  [    1]      2   X Code            0x00000000ffffe400 0x00000400 0x0000000000000009 0x00000012 __kernel_sigreturn
  [    2]      3   X Code            0x00000000ffffe420 0x00000420 0x0000000000000014 0x00000012 __kernel_vsyscall
  [    3]      4   X Data            0x0000000000000000                    0x0000000000000000 0x00000011 LINUX_2.5
  [    4]      4  SX Code            0x00000000ffffe40f 0x0000040f 0x0000000000000001 0x00000000 ___lldb_unnamed_symbol1$$[vdso]

(the load address is obviously wrong, and maybe file address as well, although I'm not sure what did we put as a file address for files that are loaded from memory)

I'm going to try to investigate more, but I'm writing here in case you have any idea what could be wrong.


Repository:
  rL LLVM

https://reviews.llvm.org/D42145