[PATCH] D43719: [WebAssembly] Do not use inheritance to define SubSection.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 27 16:24:32 PST 2018
ruiu added inline comments.
================
Comment at: lld/wasm/Writer.cpp:398
+ void writeStr(StringRef Str, StringRef Msg) {
+ lld::wasm::writeStr(OS, Str, Msg);
+ }
----------------
sbc100 wrote:
> This file doesn't use the "lld::wasm" namespace explicitly when calling these writer functions.
Yes, but without this namespace specifier, this function would call itself because it's name is also `writeStr`
https://reviews.llvm.org/D43719
More information about the llvm-commits
mailing list