[PATCH] D43711: [WebAssembly] Remove LastDefinedKind for consistency with undefined kinds. NFC.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 27 16:20:48 PST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326274: [WebAssembly] Remove LastDefinedKind for consistency with undefined kinds. NFC. (authored by ruiu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43711?vs=135764&id=136175#toc
Repository:
rL LLVM
https://reviews.llvm.org/D43711
Files:
lld/trunk/wasm/Symbols.h
Index: lld/trunk/wasm/Symbols.h
===================================================================
--- lld/trunk/wasm/Symbols.h
+++ lld/trunk/wasm/Symbols.h
@@ -39,23 +39,26 @@
DefinedFunctionKind,
DefinedDataKind,
DefinedGlobalKind,
-
- LazyKind,
UndefinedFunctionKind,
UndefinedDataKind,
UndefinedGlobalKind,
-
- LastDefinedKind = DefinedGlobalKind,
+ LazyKind,
};
Kind kind() const { return SymbolKind; }
- bool isLazy() const { return SymbolKind == LazyKind; }
- bool isDefined() const { return SymbolKind <= LastDefinedKind; }
+ bool isDefined() const {
+ return SymbolKind == DefinedFunctionKind ||
+ SymbolKind == DefinedDataKind || SymbolKind == DefinedGlobalKind;
+ }
+
bool isUndefined() const {
return SymbolKind == UndefinedFunctionKind ||
SymbolKind == UndefinedDataKind || SymbolKind == UndefinedGlobalKind;
}
+
+ bool isLazy() const { return SymbolKind == LazyKind; }
+
bool isLocal() const;
bool isWeak() const;
bool isHidden() const;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43711.136175.patch
Type: text/x-patch
Size: 1051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180228/aef3dcc2/attachment.bin>
More information about the llvm-commits
mailing list