[lld] r326274 - [WebAssembly] Remove LastDefinedKind for consistency with undefined kinds. NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 16:16:11 PST 2018


Author: ruiu
Date: Tue Feb 27 16:16:11 2018
New Revision: 326274

URL: http://llvm.org/viewvc/llvm-project?rev=326274&view=rev
Log:
[WebAssembly] Remove LastDefinedKind for consistency with undefined kinds. NFC.

Differential Revision: https://reviews.llvm.org/D43711

Modified:
    lld/trunk/wasm/Symbols.h

Modified: lld/trunk/wasm/Symbols.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Symbols.h?rev=326274&r1=326273&r2=326274&view=diff
==============================================================================
--- lld/trunk/wasm/Symbols.h (original)
+++ lld/trunk/wasm/Symbols.h Tue Feb 27 16:16:11 2018
@@ -39,23 +39,26 @@ public:
     DefinedFunctionKind,
     DefinedDataKind,
     DefinedGlobalKind,
-
-    LazyKind,
     UndefinedFunctionKind,
     UndefinedDataKind,
     UndefinedGlobalKind,
-
-    LastDefinedKind = DefinedGlobalKind,
+    LazyKind,
   };
 
   Kind kind() const { return SymbolKind; }
 
-  bool isLazy() const { return SymbolKind == LazyKind; }
-  bool isDefined() const { return SymbolKind <= LastDefinedKind; }
+  bool isDefined() const {
+    return SymbolKind == DefinedFunctionKind ||
+           SymbolKind == DefinedDataKind || SymbolKind == DefinedGlobalKind;
+  }
+
   bool isUndefined() const {
     return SymbolKind == UndefinedFunctionKind ||
            SymbolKind == UndefinedDataKind || SymbolKind == UndefinedGlobalKind;
   }
+
+  bool isLazy() const { return SymbolKind == LazyKind; }
+
   bool isLocal() const;
   bool isWeak() const;
   bool isHidden() const;




More information about the llvm-commits mailing list