[PATCH] D43697: [WebAssembly] Separate addUndefined into addUndefined{Function, Data, Global}.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 27 16:10:35 PST 2018
ruiu added inline comments.
================
Comment at: lld/wasm/SymbolTable.cpp:111
- assert(NewGlobalType != nullptr);
- const WasmGlobalType *OldType = Sym.getGlobalType();
- if (*NewGlobalType == *OldType)
- return;
+ if (!Config->CheckSignatures)
+ return;
----------------
sbc100 wrote:
> We don't need this `if`. The signature checking on functions is optional to allow certain C programs to link. Shouldn't be needed to wasm globals (which are not used in C).
Done.
https://reviews.llvm.org/D43697
More information about the llvm-commits
mailing list