[PATCH] D43833: [InstCombine] Split the FP constant code out of lookThroughFPExtensions and use nullptr as a sentinel.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:1442-1443
 static Value *lookThroughFPExtensions(Value *V) {
   while (auto *FPExt = dyn_cast<FPExtInst>(V))
     V = FPExt->getOperand(0);
 
----------------
Since we're going to fix this: a loop is unnecessary here AFAIK. isEliminableCastPair() would always squash those?


https://reviews.llvm.org/D43833