[PATCH] D43720: [WebAssembly] Do not use default argument.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 11:51:25 PST 2018


sbc100 added a comment.

Hmm. I wonder if its worth making a CustomSection subclass.  Names make no sense unless the type is `WASM_SEC_CUSTOM` so perhaps the baseclass could take only a type and the custom section could take only a string, otherwise this is going to lead to all the section constructors passing empty string.  See `Writer::createSyntheticSection` too.


https://reviews.llvm.org/D43720





More information about the llvm-commits mailing list