[PATCH] D43536: [LV] Quick workaround for PR36311, vectorizer's isUniform() abuse triggers assert in SCEV

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 10:49:33 PST 2018


hsaito added inline comments.


================
Comment at: test/Transforms/LoopVectorize/pr36311.ll:11
+; Function Attrs: uwtable
+define dso_local void @_ZN6dealii7FETools37hierarchic_to_lexicographic_numberingILi2EEENSt3__16vectorIjNS2_9allocatorIjEEEERKNS_17FiniteElementDataIXT_EEE() local_unnamed_addr #0 comdat align 2 personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
+entry:
----------------
mkazantsev wrote:
> Could you please rename this one into `@test()` and add a comment what does it check?
How about a comment like this?

; This is a test case that let's vectorizer's code gen to modify CFG and get DomTree out of date,
; such that an assert from SCEV would trigger if reanalysis of SCEV happens subsequently. 
; Once vector code gen starts, vectorizer should not invoke recomputation of Analysis.


https://reviews.llvm.org/D43536





More information about the llvm-commits mailing list