[PATCH] D43005: [ARM] Error out on .arm assembler directives on windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D43005#1020699, @peter.smith wrote:

> To summarise:
>
> - It should be possible to accomplish what you want by using just the featurebits. Can you elaborate on why this doesn't work for you?


The big question I have is, where should I initialize/override those feature bits? I see it done statically for different architecture variants in ARM.td, but here it should be set not only based on cpu but based on the OS. The existing case of setting a similar flag is done in ARMSubtarget.cpp, but when just invoking the assembler, ARMSubtarget is never constructed at all. So where should I place the code that sets the FeatureNoARM bit when OS == Windows, so that it gets set when invoking the assembler?

> - I suggest renaming or removing hasARMOps(), have I misunderstood what it is used for?

I'd rather extend it to not only check for windows but also check for the FeatureNoARM bit (and if we resolve the above issue, check only that) - then it would be more useful.


Repository:
  rL LLVM

https://reviews.llvm.org/D43005