[PATCH] D43781: Make AddrSpaceCast noops on PPC

[Valentin Churavy via llvm-commits]

I will think about a test case.
The main motivation is that a frontend might generate code that contains
address-space casts and the PPC backend cannot select these address-space
casts since IIUC PPC has no notion of address-spaces. AArch64 is in a
similar position and follows the same tactic (see
https://github.com/llvm-mirror/llvm/blob/f0454dcc5c809cf31155d6fe12db756fe4718b45/lib/Target/AArch64/AArch64ISelLowering.h#L277-L280
).




On Mon, 26 Feb 2018 at 20:53 Nemanja Ivanovic via Phabricator <
reviews at reviews.llvm.org> wrote:

> nemanjai added a comment.
>
> This seems like a perfectly reasonable thing to do. However, I'd like to
> understand the implications of this change - does anything change behaviour
> as a result? If so, can we have a test case? If not, does this just save
> compile time (i.e. we don't insert casts that will just be cleaned up
> anyway)? Even if the change is only internal to the SDAG processing and the
> final code doesn't change, would it be possible to have an MIR test case
> that shows the difference?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43781
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180227/6bb28992/attachment.html>