[PATCH] D43414: AMDGPU: Define FP_FAST_FMA{F} macros for amdgcn

[Tony Tye via Phabricator via llvm-commits]

t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.

LGTM except for comment on deprecated macros.



================
Comment at: lib/Basic/Targets/AMDGPU.cpp:346-347
 
-  if (hasFMAF)
+  // TODO: __HAS_FMAF__, __HAS_LDEXPF__, __HAS_FP64__ are deprecated and will be
+  // removed in the near future.
+  if (GPU.HasFMAF)
----------------
@b-sumner which ones were to recommending deprecating? I would think FP64 and FMAF would be ones that needs to be kept? I thought it was __HAS_FAST_FMA__ that is not specified by OpenCL.


https://reviews.llvm.org/D43414