[PATCH] D43668: [XRay] [compiler-rt] Implement trampoline and handler for typed xray event tracing.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: include/xray/xray_interface.h:88
+extern uint32_t
+__xray_register_event_type(const char *const event_type) noexcept;
+
----------------
kpw wrote:
> dberris wrote:
> > I don't think you need the additional `const` for the declaration.
> > 
> > Also, I suspect 'noexcept' in the `extern "C" { ... }` section wouldn't make any sense, and would be superfluous.
> Fair enough about the const.
> 
> I wasn't sure if extern "C" only specified linkage. Digging was inconclusive.
> 
> https://stackoverflow.com/questions/24362616/does-the-c-standard-mandate-that-c-linkage-functions-are-noexcept
The noexcept doesn't really add much here, and could be distracting, and is not something we can guarantee either. Is there something in particular you're guarding for with putting the noexcept specifier(s) on these functions?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43668