[PATCH] D43213: [Fuzzer] Avoid the unnecessary rebuild of the custom libc++
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 26 18:07:59 PST 2018
phosek added a comment.
In https://reviews.llvm.org/D43213#1020058, @morehouse wrote:
> In https://reviews.llvm.org/D43213#1020043, @phosek wrote:
>
> > In https://reviews.llvm.org/D43213#1016841, @morehouse wrote:
> >
> > > Why not just call `llvm_ExternalProject_Add` rather than duplicating here?
> >
> >
> > Don't we still want to support the setup where compiler-rt is built as a standalone project in which case `llvm_ExternalProject_Add` wouldn't be available?
>
>
> In that case, `llvm_ExternalProject_BuildCmd` won't be available either but is still used by this patch.
That's a mistake, thanks for catching that!
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D43213
More information about the llvm-commits
mailing list