[PATCH] D43687: Improve merging of debug locations (fixes PR 36410)

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 16:44:01 PST 2018


dblaikie added a comment.

Have you considered a test case where there's a common scope within an inlinedAt location?

  SP1 <- S1 <- IA1 <- L1
           \-- IA2 <- L2

I think it's reasonable for S1 to be the scope of the merged location - as much as it would be if IA1 and IA2 were not present. (SP = Subprogram, S = Scope, IA = InlinedAt, L = Location).

I /think/ this should be achievable with a single walk, rather than two separate walks (one up scopes, one up inlinedAt's), perhaps?


Repository:
  rL LLVM

https://reviews.llvm.org/D43687





More information about the llvm-commits mailing list