[PATCH] D43770: [NewGVN] Update phi-of-ops def block when updating existing ValuePHI.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 11:20:21 PST 2018


dberlin added a comment.

This is definitely correct.
Note that this also means we are likely leaving around TempToBlock mappings for ops because we don't remove them in removePhiOfOps.
(But that would require reference counting ATM, i believe, because they may be reused).
This shouldn't hurt anything, i believe.


https://reviews.llvm.org/D43770





More information about the llvm-commits mailing list