[PATCH] D43708: [DAE] don't remove args of musttail target/caller

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I'm not sure I know enough about the subject matter to give more than a superficial review.



================
Comment at: lib/Transforms/IPO/DeadArgumentElimination.cpp:512
+
+  for (Function::const_iterator BB = F.begin(), E = F.end(); BB != E; ++BB) {
+    if (const ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator())) {
----------------
range-based-for?


================
Comment at: test/Transforms/DeadArgElim/musttail-caller.ll:2
+; RUN: opt -deadargelim -S < %s | FileCheck %s
+; PR36441
+
----------------
It would be better to write a comment here explaining what behavior is being tested instead of just referring to the PR>.


https://reviews.llvm.org/D43708