[PATCH] D43539: Add new interceptors: getttyent(3) family

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:464
 #define SANITIZER_INTERCEPT_STRMODE SI_NETBSD
+#define SANITIZER_INTERCEPT_GETTTYENT SI_NETBSD
 
----------------
vitalybuka wrote:
> Why only NETBSD?
I can assure only NetBSD. Feel free to switch it to POSIX or other combination of OSes in a new commit.


================
Comment at: test/sanitizer_common/TestCases/NetBSD/getttyent.cc:77
+  test1();
+  test2();
+  test3();
----------------
vitalybuka wrote:
> Maybe some checks if you print it?
I was thinking about it, however this setup uses the global configuration of a system that might be (and usually is) customized. It's easier with e.g. protoent, as protocol entries aren't usually modified.


Repository:
  rL LLVM

https://reviews.llvm.org/D43539