[PATCH] D43499: [SCEV] Introduce SCEVPostIncRewriter

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:4142
+  static const SCEV *rewrite(const SCEV *S, const Loop *L, ScalarEvolution &SE,
+                             bool IgnoreOtherLoops = false) {
+    SCEVPostIncRewriter Rewriter(L, SE);
----------------
skatkov wrote:
> sanjoy wrote:
> > We don't need `IgnoreOtherLoops` right?  If so, let's remove it for now.
> If I understood it correctly the idea is just to remove it for now to make  patch mostly NFC (related to D43498) and add it when we need it in "IsKnownPredicated Fix" patch. Ok, I'll do that.
No, I meant always have the behavior be to ignore other loops (so you don't have to change anything in D43498).

You might also want to change `SCEVInitRewriter` default `IgnoreOtherLoops` to `true` for consistency.


https://reviews.llvm.org/D43499