[PATCH] D43746: [WebAssembly] Add Wasm exception handling prepare pass

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/CodeGen/WasmEHPrepare.cpp:288-291
+  // If this is not a top level landing pad, i.e., there is another landing pad
+  // that dominates this landing pad, we don't need to store LSDA address again,
+  // because they are the same throughout the function and have been already
+  // stored before.
----------------
majnemer wrote:
> What if this landing pad is dominated by two landing pads which are both top-level?
It's OK because the LSDA address is the same throughout a function. Actually we can store it just once in the entry block and that would be sufficient, but that would incur additional cost even when no exception occurs, so I didn't do that.


Repository:
  rL LLVM

https://reviews.llvm.org/D43746