[PATCH] D43539: Add new interceptors: getttyent(3) family

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:6862
+}
+INTERCEPTOR(int, setttyent) {
+  void *ctx;
----------------
vitalybuka wrote:
> it does not check anything, why do you want to intercept it?
> same for endttyent
Disable recursive interceptors.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7121
 
 #if SANITIZER_NETBSD
   COMMON_INTERCEPT_FUNCTION(__libc_mutex_lock);
----------------
vitalybuka wrote:
> Could you please convert this peace into INIT_ style?
> As a separate patch.
> Trivial but I can't be sure that it compiles if I do it myself.
Do you mean, `__libc_mutex_lock` and the others bellow?


Repository:
  rL LLVM

https://reviews.llvm.org/D43539