[PATCH] D40546: StructurizeCFG: Test for branch divergence correctly

[Nicolai Hähnle via llvm-commits]

On 24.02.2018 21:50, Daniel Berlin wrote:
> The last thing on this review thread is a request for a review, then it 
> gets committed, breaking stuff.
> What happened here?

No, the last thing on the review thread is the change being accepted.

Sorry I didn't see the rest in time, but it *is* the weekend and the 
failures did not show up in local testing of all targets that could 
possibly be affected.

Cheers,
Nicolai


> 
> 
> On Sat, Feb 24, 2018 at 9:33 AM, Adam Nemet via llvm-commits 
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> 
>     Bots have been failing for a day now.  Reverted in r326037.
> 
>>     On Feb 23, 2018, at 12:44 PM, Quentin Colombet via llvm-commits
>>     <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>>
>>     wrote:
>>
>>     FWIW, I have the same problem as Sanjay.
>>
>>     Here is the output of the failure:
>>     ; GCN: s_cmp_eq_u32
>>             ^
>>     <stdin>:104:21: note: scanning from here
>>       s_or_b64 exec, exec, s[10:11]
>>                          ^
>>     <stdin>:106:2: note: possible intended match here
>>       v_cmp_eq_u32_e64 s[10:11], s4, v0
>>       ^
>>
>>
>>>     On Feb 23, 2018, at 12:23 PM, Sanjay Patel via Phabricator via
>>>     llvm-commits <llvm-commits at lists.llvm.org
>>>     <mailto:llvm-commits at lists.llvm.org>> wrote:
>>>
>>>     spatel added a comment.
>>>
>>>     I'm not sure if it was this change or something else, but the
>>>     optnone test is not stable on my system (testing with llc built
>>>     from r325923):
>>>
>>>      $ ./llvm-lit ../../llvm/test/CodeGen/AMDGPU/control-flow-optnone.ll
>>>      -- Testing: 1 tests, 1 threads --
>>>      PASS: LLVM :: CodeGen/AMDGPU/control-flow-optnone.ll (1 of 1)
>>>      Testing Time: 0.11s
>>>        Expected Passes    : 1
>>>      $ ./llvm-lit ../../llvm/test/CodeGen/AMDGPU/control-flow-optnone.ll
>>>      -- Testing: 1 tests, 1 threads --
>>>      FAIL: LLVM :: CodeGen/AMDGPU/control-flow-optnone.ll (1 of 1)
>>>      Testing Time: 0.11s
>>>      ********************
>>>      Failing Tests (1):
>>>          LLVM :: CodeGen/AMDGPU/control-flow-optnone.ll
>>>
>>>     I also got blame mail from a bot about this test failing for what
>>>     would seem to be an unrelated change:
>>>     http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/7201
>>>     <http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/7201>
>>>
>>>
>>>     Repository:
>>>      rL LLVM
>>>
>>>     https://reviews.llvm.org/D40546 <https://reviews.llvm.org/D40546>
>>>
>>>
>>>
>>>     _______________________________________________
>>>     llvm-commits mailing list
>>>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>     <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>>
>>     _______________________________________________
>>     llvm-commits mailing list
>>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>     <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 
> 
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>     <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.