[PATCH] D43676: [ubsan-minimal] Fix the ubsan_minimal debug build (COMPILER_RT_DEBUG=1) on macOS

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 24 05:14:30 PST 2018


delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: lib/ubsan_minimal/ubsan_minimal_handlers.cc:68
+void NORETURN CheckFailed(const char *file, int line, const char *cond, u64 v1,
+                          u64 v2) {
+  message("Sanitizer CHECK failed: ");
----------------
vsk wrote:
> Could you omit the parameter names for the unused arguments? This should appease some picky buildbots.
Done.

The fact that this wasn't caught before though probably means we are missing a build bot configuration for macOS.


https://reviews.llvm.org/D43676





More information about the llvm-commits mailing list