[PATCH] D43713: [WebAssembly] Inline accessor functions that are called only once.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 20:08:53 PST 2018


ruiu created this revision.
ruiu added a reviewer: sbc100.
Herald added subscribers: sunfish, aheejin, jgravelle-google, dschuff, jfb.

Looks like these accessor functions are a bit overly defensive, and
due to the amount of code, that part isn't easy to read. We have
code to log translation results in writeTo and writeRelocations, so
I don't think we need to log it again in these functions.
I think the new function is much easier to understand.


https://reviews.llvm.org/D43713

Files:
  lld/wasm/InputFiles.cpp
  lld/wasm/InputFiles.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43713.135770.patch
Type: text/x-patch
Size: 4623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180224/8a993e3e/attachment.bin>


More information about the llvm-commits mailing list