[PATCH] D43704: Utility functions for checked arithmetic

[George Karpenkov via Phabricator via llvm-commits]

george.karpenkov marked 3 inline comments as done.
george.karpenkov added inline comments.


================
Comment at: lib/Support/MathExtras.cpp:29
+    int64_t RHS,
+    std::function<llvm::APInt(llvm::APInt *, const llvm::APInt &, bool &)> Op,
+    int64_t *Res = nullptr) {
----------------
vsk wrote:
> llvm::function_ref is more appropriate for non-owning callables.
...except it does not work here, and I don't think it's worth it to investigate why


https://reviews.llvm.org/D43704