[PATCH] D43669: [cfi] Lazy CFI initialization

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/cfi/cfi.cc:416
+
+  INTERCEPT_FUNCTION(dlopen);
+  INTERCEPT_FUNCTION(dlclose);
----------------
This is technically a data race. Let's just take a lock, this is not performance sensitive.


================
Comment at: compiler-rt/lib/cfi/cfi.cc:416
-  INTERCEPT_FUNCTION(dlclose);
-
 #ifdef CFI_ENABLE_DIAG
----------------
eugenis wrote:
> This is technically a data race. Let's just take a lock, this is not performance sensitive.
call EnsureInterceptorsInitialized() here, or it may become a surprise if someone adds a new interceptor without that check


https://reviews.llvm.org/D43669