[PATCH] D42712: [utils] Add utils/update_cc_test_checks.py

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 18:07:13 PST 2018


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: utils/UpdateTestChecks/asm.py:97
   asm = SCRUB_X86_LCP_RE.sub(r'{{\.LCPI.*}}', asm)
-  if args.x86_extra_scrub:
+  if getattr(args, 'x86_extra_scrub', False):
     # Avoid generating different checks for 32- and 64-bit because of 'retl' vs 'retq'.
----------------
echristo wrote:
> Hmm?
So that it will not warn that `args` (parsed command line options) does not have the attribute.


Repository:
  rL LLVM

https://reviews.llvm.org/D42712





More information about the llvm-commits mailing list