[PATCH] D43661: [llvm-objcopy] Fix typo in setSymTab and make setters private.
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 23 16:44:16 PST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326005: [llvm-objcopy] Fix typo in setSymTab (authored by alexshap, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43661?vs=135566&id=135733#toc
Repository:
rL LLVM
https://reviews.llvm.org/D43661
Files:
llvm/trunk/tools/llvm-objcopy/Object.h
Index: llvm/trunk/tools/llvm-objcopy/Object.h
===================================================================
--- llvm/trunk/tools/llvm-objcopy/Object.h
+++ llvm/trunk/tools/llvm-objcopy/Object.h
@@ -343,14 +343,15 @@
class SymbolTableSection : public SectionBase {
MAKE_SEC_WRITER_FRIEND
+ void setStrTab(StringTableSection *StrTab) { SymbolNames = StrTab; }
+
protected:
std::vector<std::unique_ptr<Symbol>> Symbols;
StringTableSection *SymbolNames = nullptr;
using SymPtr = std::unique_ptr<Symbol>;
public:
- void setStrTab(StringTableSection *StrTab) { SymbolNames = StrTab; }
void addSymbol(StringRef Name, uint8_t Bind, uint8_t Type,
SectionBase *DefinedIn, uint64_t Value, uint8_t Visibility,
uint16_t Shndx, uint64_t Sz);
@@ -403,12 +404,12 @@
class RelocSectionWithSymtabBase : public RelocationSectionBase {
private:
SymTabType *Symbols = nullptr;
+ void setSymTab(SymTabType *SymTab) { Symbols = SymTab; }
protected:
RelocSectionWithSymtabBase() = default;
public:
- void setSymTab(SymTabType *StrTab) { Symbols = StrTab; }
void removeSectionReferences(const SectionBase *Sec) override;
void initialize(SectionTableRef SecTable) override;
void finalize() override;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43661.135733.patch
Type: text/x-patch
Size: 1267 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180224/8bcf9e49/attachment.bin>
More information about the llvm-commits
mailing list