[PATCH] D43702: [asan] Fix bug where suppression of overlapping accesses was ignored.

[Dan Liew via Phabricator via llvm-commits]

delcypher created this revision.
delcypher added reviewers: kubamracek, alekseyshl, mcgrathr, eugenis, kcc.
Herald added a subscriber: Sanitizers.

[asan] Fix bug where suppression of overlapping accesses (e.g.`strncpy()`) was ignored.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43702

Files:
  lib/asan/asan_interceptors_memintrinsics.h
  test/asan/TestCases/strncpy-overlap.cc


Index: test/asan/TestCases/strncpy-overlap.cc
===================================================================
--- /dev/null
+++ test/asan/TestCases/strncpy-overlap.cc
@@ -0,0 +1,39 @@
+// RUN: %clangxx_asan -O0 %s -o %t
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
+// RUN: echo "interceptor_via_fun:bad_function" > %t.supp
+// RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t
+//
+// RUN: %clangxx_asan -O1 %s -o %t
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
+// RUN: echo "interceptor_via_fun:bad_function" > %t.supp
+// RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t
+//
+// RUN: %clangxx_asan -O2 %s -o %t
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
+// RUN: echo "interceptor_via_fun:bad_function" > %t.supp
+// RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t
+//
+// RUN: %clangxx_asan -O3 %s -o %t
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
+// RUN: echo "interceptor_via_fun:bad_function" > %t.supp
+// RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t
+
+#include <string.h>
+
+
+// Don't inline function otherwise stacktrace changes.
+__attribute__((noinline)) void bad_function() {
+  char buffer[] = "hello";
+  // CHECK: strncpy-param-overlap: memory ranges
+  // CHECK: [{{0x.*,[ ]*0x.*}}) and [{{0x.*,[ ]*0x.*}}) overlap
+  // CHECK-Linux: {{#0 0x.* in .*strncpy}}
+  // CHECK-Darwin: {{#0 0x.* in wrap_strncpy}}
+  // CHECK: {{#1 0x.* in bad_function.*strncpy-overlap.cc:}}[[@LINE+2]]
+  // CHECK: {{#2 0x.* in main .*strncpy-overlap.cc:}}[[@LINE+5]]
+  strncpy(buffer, buffer + 1, 5); // BOOM
+}
+
+int main(int argc, char **argv) {
+  bad_function();
+  return 0;
+}
Index: lib/asan/asan_interceptors_memintrinsics.h
===================================================================
--- lib/asan/asan_interceptors_memintrinsics.h
+++ lib/asan/asan_interceptors_memintrinsics.h
@@ -133,15 +133,20 @@
                                  const char *offset2, uptr length2) {
   return !((offset1 + length1 <= offset2) || (offset2 + length2 <= offset1));
 }
-#define CHECK_RANGES_OVERLAP(name, _offset1, length1, _offset2, length2) do { \
-  const char *offset1 = (const char*)_offset1; \
-  const char *offset2 = (const char*)_offset2; \
-  if (RangesOverlap(offset1, length1, offset2, length2)) { \
-    GET_STACK_TRACE_FATAL_HERE; \
-    ReportStringFunctionMemoryRangesOverlap(name, offset1, length1, \
-                                            offset2, length2, &stack); \
-  } \
-} while (0)
+#define CHECK_RANGES_OVERLAP(name, _offset1, length1, _offset2, length2)       \
+  do {                                                                         \
+    const char *offset1 = (const char *)_offset1;                              \
+    const char *offset2 = (const char *)_offset2;                              \
+    if (RangesOverlap(offset1, length1, offset2, length2)) {                   \
+      GET_STACK_TRACE_FATAL_HERE;                                              \
+      bool suppressed =                                                        \
+          HaveStackTraceBasedSuppressions() && IsStackTraceSuppressed(&stack); \
+      if (!suppressed) {                                                       \
+        ReportStringFunctionMemoryRangesOverlap(name, offset1, length1,        \
+                                                offset2, length2, &stack);     \
+      }                                                                        \
+    }                                                                          \
+  } while (0)
 
 }  // namespace __asan
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43702.135727.patch
Type: text/x-patch
Size: 3719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180224/d946422f/attachment.bin>