[PATCH] D43701: [cmake] Store LLVM_VERSION_SUFFIX in LLVMConfig.cmake

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 16:01:27 PST 2018


mgorny created this revision.
mgorny added reviewers: beanz, chapuni.

Store LLVM_VERSION_SUFFIX along with other version components
in LLVMConfig.cmake. This fixes preserving the suffix set while building
LLVM to stand-alone builds of other components, e.g. clang,
and therefore improves uniformity between the two build models.

Given that there is no apparent reason to omit this part of version,
that it is distributed to subprojects when building as part of LLVM
and that it is included in LLVM_PACKAGE_VERSION, I think it was omitted
accidentally rather than on purpose.


Repository:
  rL LLVM

https://reviews.llvm.org/D43701

Files:
  cmake/modules/LLVMConfig.cmake.in


Index: cmake/modules/LLVMConfig.cmake.in
===================================================================
--- cmake/modules/LLVMConfig.cmake.in
+++ cmake/modules/LLVMConfig.cmake.in
@@ -5,6 +5,7 @@
 set(LLVM_VERSION_MAJOR @LLVM_VERSION_MAJOR@)
 set(LLVM_VERSION_MINOR @LLVM_VERSION_MINOR@)
 set(LLVM_VERSION_PATCH @LLVM_VERSION_PATCH@)
+set(LLVM_VERSION_SUFFIX @LLVM_VERSION_SUFFIX@)
 set(LLVM_PACKAGE_VERSION @PACKAGE_VERSION@)
 
 set(LLVM_BUILD_TYPE @CMAKE_BUILD_TYPE@)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43701.135724.patch
Type: text/x-patch
Size: 475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180224/f626c640/attachment.bin>


More information about the llvm-commits mailing list